Elements: Fix instance element styles for links applying to buttons #6127
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| 'selector' => ".$class_name a:where(:not(.wp-element-button))", | ||
| 'hover_selector' => ".$class_name a:where(:not(.wp-element-button)):hover", |
There was a problem hiding this comment.
Why not use a:not(.wp-element-button)?
There was a problem hiding this comment.
Thanks for the question @mukeshpanchal27, I take it you mean "why not use :not"?
This selector uses the :where to reduce specificity and make it easier for themes to override the link element styles as desired.
In the case of this PR, it's a bug fix that prevents the misapplication of the link element styles to buttons but by using the same selector as theme.json it also avoids increasing the specificity. This keeps the ease of overriding styles if a theme desires while still resulting in the expected behaviour.
The original PR introducing the lowered specificity for link element styles in theme.json can be found in WordPress/gutenberg#42669. That was backported in #3206.
4 participants
Syncs the changes from WordPress/gutenberg#59114
These changes fix the selector used by block instance element styles for links so they do not get incorrectly applied to buttons.
To test:
npm run test:php -- --filter Tests_Block_Supports_WpRenderElementsSupportTrac ticket: https://core.trac.wordpress.org/ticket/60557
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.